Possibly leaking DOM node references

[kevinrobinson]

I ran into this doing some profiling as part of kevinrobinson#1. It looks like there's a DOM leak somewhere.

You can see the test case I'm using here on the counters app:

This might not matter much in real applications, and I'm not quite sure how to investigate further. I tried seeing if I could find more in the profiling tools but didn't get anywhere yet. I also read through the code to see if anything stuck out but couldn't see anything there either.

Maybe someone else knows more about profiling this, or can track it down?

[acdlite]

Damn, if that's true where the hell is it happening? The only possible candidates I can think of are Connector (which looks to be unsubscribing correctly on unmount) or the Redux class. Everything else is a pure function!

Oh, could you try testing on this branch: https://github.com/gaearon/redux/tree/breaking-changes-1.0? The dispatcher has been removed and the Redux/Store class has been cleaned up considerably. Maybe the leak has already been plugged.

[acdlite]

Actually if the leak is related to DOM nodes then I can't imagine how it would be related to Redux...

[kevinrobinson]

@acdlite Yeah I'm stumped at the moment too. One thought was that perhaps the GC cycle is just longer for DOM nodes and it hadn't kicked in yet? That's just a straight guess though.

[kevinrobinson]

@acdlite Not sure, ran into this.

Also since I've seen you online but don't think we've ever chatted, you're doing awesome work! :)

[acdlite]

@kevinrobinson Same to you!

[gaearon]

Closing in favor of reduxjs/react-redux#3.