Skip to content

Resubscribe logic ignoring Pub/Sub shard channels after reconnect. #2940 #3024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tishun merged 1 commit into from
Oct 24, 2024
Merged

Resubscribe logic ignoring Pub/Sub shard channels after reconnect. #2940 #3024

tishun merged 1 commit into from
Oct 24, 2024

Conversation

@ggivo
Copy link
Contributor

@ggivo ggivo commented Oct 24, 2024 •
edited by tishun
Loading

Closes #2940

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@ggivo ggivo force-pushed the 2940-resubscribe-ignoring-sshardchannels branch from d4aee34 to f4e7242 Compare October 24, 2024 06:25
@ggivo ggivo requested a review from tishun October 24, 2024 06:26
@ggivo ggivo self-assigned this Oct 24, 2024
@ggivo ggivo added the type: bug A general bug label Oct 24, 2024
tishun
tishun approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tishun tishun merged commit 8114354 into redis:main Oct 24, 2024
thachlp pushed a commit to thachlp/lettuce that referenced this pull request Dec 31, 2024
@ggivo @thachlp
Closes redis#2940 Sharded PubSub subscriptions not recovered after di…
e6c7919 
…sconnection and re-connection. (redis#3024)
@ggivo ggivo deleted the 2940-resubscribe-ignoring-sshardchannels branch January 30, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tishun tishun tishun approved these changes

Assignees

@ggivo ggivo

Labels

type: bug A general bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

resubscribe logic looks ignoring sharded Pub/Sub (shardChannels Set of PubSubEndpoint)

2 participants

@ggivo @tishun