refactor: move CLIENT SETINFO commands to connection handshake #2033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 20, 2025
PavelPashov
force-pushed
the
refactor/relocate-client-setinfo-commands
branch
from
02e4a99 to
f025d4b
Compare
PavelPashov
force-pushed
the
refactor/relocate-client-setinfo-commands
branch
from
dbc7ead to
5c9a2e9
Compare
PavelPashov
force-pushed
the
refactor/relocate-client-setinfo-commands
branch
from
0a8ca39 to
721008d
Compare
nkaradzhov
approved these changes
Oct 21, 2025
|
🎉 This PR is included in version 5.8.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
simong
added a commit
to simong/ioredis
that referenced
this pull request
Nov 3, 2025
* origin/main: chore(release): 5.8.2 [skip ci] fix: move CLIENT SETINFO commands to connection handshake (redis#2033) ci(test): add redis matrix and update docker compose file (redis#2034) docs(example): add example for setting TTL to "HSET Field" (redis#2027) fix: default IP family selection to 0 (redis#2028) chore(release): 5.8.1 [skip ci] test: add scenario tests v5 (redis#2020) fix(ssubscribe): re-subscribe sharded pubsub channels individually (redis#2021) chore(release): 5.8.0 [skip ci] feat: support client setinfo (redis#2011) feat(stream): Add XDELEX command (redis#2003) Add stale issue management workflow (redis#2018) feat: implement proper hpexpire command signatures and tests (redis#2006) feat: add more xtrim method overloads and tests (redis#2010) test(cluster): fix and add cluster tests in CI (redis#2017) Force slots refresh on MOVED error when using ssubscribe (redis#2013) fix(ssubscribe): re-subscribe sharded pubsub channels individually on ready (redis#2012) chore(release): 5.7.0 [skip ci] fix: xread example for TypeScript (redis#1872) feat: Implement hexpire for redis#1898 (redis#1918)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes several issues related to the
CLIENT SETINFOcommands:2030 & 2031 When using
reconnectOnErrorin client configurations with Redis servers older than version 7.2.x. In these cases,ioredisattempts to execute theCLIENT SETINFOcommand, which is not supported in older Redis versions. When combined withreconnectOnError, this results in continuous reconnection attempts. To address this, anIGNORE_RECONNECT_ON_ERRORcommand flag has been introduced, currently applied only to theCLIENTcommand.2031 When using cluster with autopipelining. The
CLIENTcommand should be included in thenotAllowedAutoPipelineCommands2025 When using
DragonflyDB, now theCLIENT SETINFOcommands are issued in theconnectHandlerinstead of thereadyHandler