Skip to content

fixed #2462 v9 continue support dragonfly, it's Hello command return "NOAUTH Authentication required" error #2479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
monkey92t merged 4 commits into from
Mar 10, 2023
Merged

fixed #2462 v9 continue support dragonfly, it's Hello command return "NOAUTH Authentication required" error #2479

monkey92t merged 4 commits into from
Mar 10, 2023

Conversation

@xinzhanguo
Copy link
Contributor

@xinzhanguo xinzhanguo commented Mar 9, 2023 •
edited
Loading

See #2462

dragonfly dont support hello command, it's return "NOAUTH Authentication required" when use Hello command.

@xinzhanguo xinzhanguo changed the title fixed #2462 error NOAUTH and support dragonfly fixed #2462 v9 continue support dragonfly, it's Hello command return "NOAUTH Authentication required" error Mar 9, 2023
@monkey92t
Copy link
Collaborator

monkey92t commented Mar 9, 2023 •
edited
Loading

We should maintain compatibility with redis, not dragonfly.
We shouldn't support multiple systems at the same time, like protobuf supporting JSON is a bad thing.
If dragonfly and redis part ways in the future, it will be a disaster for go-redis.

If you need dragonfly, you can create a new warehouse based on go-redis to support dragonfly 😄

/cc @vmihailenco

@vmihailenco
Copy link
Collaborator

vmihailenco commented Mar 10, 2023

If this is all that is needed to support DragonflyDB, then I am fine with keeping it. It is a tiny change that does not cost us anything.

vmihailenco
vmihailenco reviewed Mar 10, 2023
View reviewed changes
@monkey92t
Copy link
Collaborator

monkey92t commented Mar 10, 2023

We accept this PR, but we do not guarantee compatibility with dragonfly.

@monkey92t monkey92t merged commit 30a6f71 into redis:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@vmihailenco vmihailenco vmihailenco approved these changes

@monkey92t monkey92t monkey92t approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xinzhanguo @monkey92t @vmihailenco