-
Notifications
You must be signed in to change notification settings - Fork 186
W/A for multi platform deployment issue #13978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
W/A for multi platform deployment issue #13978
Conversation
We have serious issue in design and how the deployment is implemented for multicluster scenarios as only single deployer class object is initiated and then we cannot rely on it when we iterating over multiple clusters in underlaying deployment methods for do_deploy_rdr and so on. Issue: https://issues.redhat.com/browse/OCSQE-4214 I am tryin to W/A this on curcial parts to rely on config values which should be specific for concrete cluster. But to fix this properly will require bigger refactoring and broader discussion with team. Signed-off-by: Petr Balogh <[email protected]>
61eacd0 to
b7b5a33
Compare
ocs-ci
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: deployment
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.21
OCS VERSION: 4.21
tested against branch: master
Job FAILED (installation failed, tests not executed).
Signed-off-by: Petr Balogh <[email protected]>
ocs-ci
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: deployment
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.21
OCS VERSION: 4.21
tested against branch: master
ocs-ci
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: deployment
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.21
OCS VERSION: 4.21
tested against branch: master
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: clacroix12, petr-balogh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
We have serious issue in design and how the deployment is implemented for multicluster scenarios as only single deployer class object is initiated and then we cannot rely on it when we iterating over multiple clusters in underlaying deployment methods for do_deploy_rdr and so on.
Issue:
https://issues.redhat.com/browse/OCSQE-4214
I am tryin to W/A this on curcial parts to rely on config values which should be specific for concrete cluster.
But to fix this properly will require bigger refactoring and broader discussion with team.