Skip to content

Conversation

@petr-balogh
Copy link
Member

We have serious issue in design and how the deployment is implemented for multicluster scenarios as only single deployer class object is initiated and then we cannot rely on it when we iterating over multiple clusters in underlaying deployment methods for do_deploy_rdr and so on.

Issue:
https://issues.redhat.com/browse/OCSQE-4214

I am tryin to W/A this on curcial parts to rely on config values which should be specific for concrete cluster.

But to fix this properly will require bigger refactoring and broader discussion with team.

@petr-balogh petr-balogh requested a review from a team as a code owner December 19, 2025 17:44
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Dec 19, 2025
We have serious issue in design and how the deployment is implemented
for multicluster scenarios as only single deployer class object is
initiated and then we cannot rely on it when we iterating over multiple
clusters in underlaying deployment methods for do_deploy_rdr and so on.

Issue:
https://issues.redhat.com/browse/OCSQE-4214

I am tryin to W/A this on curcial parts to rely on config values which
should be specific for concrete cluster.

But to fix this properly will require bigger refactoring and broader
discussion with team.

Signed-off-by: Petr Balogh <[email protected]>
@petr-balogh petr-balogh force-pushed the fix-multi-platform-deployment branch from 61eacd0 to b7b5a33 Compare December 19, 2025 18:11
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: deployment
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.21
OCS VERSION: 4.21
tested against branch: master

Job FAILED (installation failed, tests not executed).

Signed-off-by: Petr Balogh <[email protected]>
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: deployment
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.21
OCS VERSION: 4.21
tested against branch: master

Job PASSED.

@petr-balogh petr-balogh added the Verified Mark when PR was verified and log provided label Dec 19, 2025
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: deployment
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.21
OCS VERSION: 4.21
tested against branch: master

Job PASSED.

@openshift-ci
Copy link

openshift-ci bot commented Dec 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: clacroix12, petr-balogh

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm size/L PR that changes 100-499 lines Verified Mark when PR was verified and log provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants