Skip to content

Use Automated Way to configure Importing MCE based cluster to ACM #13942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
prsurve wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use Automated Way to configure Importing MCE based cluster to ACM #13942

prsurve wants to merge 3 commits into from

Conversation

@prsurve
Copy link
Contributor

@prsurve prsurve commented Dec 15, 2025

No description provided.

@prsurve prsurve requested a review from a team as a code owner December 15, 2025 14:05
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Dec 15, 2025
@prsurve prsurve added DR Metro and Regional DR related PRs provider-client Provider-client solution provider mode deployment Issues preventing Provider mode deployments on any stage labels Dec 15, 2025
jilju
jilju previously approved these changes Dec 15, 2025
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Dec 15, 2025
@prsurve
Copy link
Contributor Author

prsurve commented Dec 15, 2025

Need to revisit label part

addon_deployment_config.add_label(label=backup_label)
2025-12-15 21:13:45 E TypeError: OCP.add_label() missing 1 required positional argument: 'resource_name'

@prsurve
fix label issue
9d9559b 
Signed-off-by: prsurve <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Dec 15, 2025
@prsurve
Copy link
Contributor Author

prsurve commented Dec 15, 2025

Need to revisit label part

addon_deployment_config.add_label(label=backup_label) 2025-12-15 21:13:45 E TypeError: OCP.add_label() missing 1 required positional argument: 'resource_name'

Done

@prsurve prsurve added Verified Mark when PR was verified and log provided and removed do-not-merge/hold labels Dec 15, 2025
@openshift-ci openshift-ci bot added the lgtm label Dec 16, 2025
@openshift-ci
Copy link

openshift-ci bot commented Dec 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jilju, prsurve

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Collaborator

openshift-merge-robot commented Dec 16, 2025

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jilju jilju jilju approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@jilju jilju

Labels

DR Metro and Regional DR related PRs lgtm needs-rebase provider mode deployment Issues preventing Provider mode deployments on any stage provider-client Provider-client solution size/L PR that changes 100-499 lines Verified Mark when PR was verified and log provided

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prsurve @openshift-merge-robot @jilju