Implement postfix parsing #953
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunxing
reviewed
Jan 12, 2017
Contributor
yunxing
left a comment
yunxing
left a comment
There was a problem hiding this comment.
Looks good. Waiting for the test and printer change.
src/reason_lexer.mll
Outdated
| | postfix_chars | ||
| { | ||
| let l = Lexing.lexeme lexbuf in | ||
| POSTFIX (remove_numbers l, int_of_string (remove_chars l)) |
Contributor
There was a problem hiding this comment.
Nit: instead of using two functions, is it possible to just do one pass and return both number part and string part?
Member
|
Thanks for the change! Btw #637 is pretty early. Let's see if people still want postfix... |
Contributor
Author
|
Added printer support also and tests. |
Contributor
Author
|
@chenglou This PR will be waiting patiently |
|
:+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#637
Work in progress.
Changes:
50Catsto
Cats 50.Printing still needs to be done to finish this.