Skip to content

wip: Rewrite reason_pprint_ast with pprint library #2699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SanderSpies wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

wip: Rewrite reason_pprint_ast with pprint library #2699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2f5645a
Add history entry.
SanderSpies Mar 6, 2023
b6e1805
wip: pprint experiment
SanderSpies Mar 16, 2023
ca8d8fd
Remove accidental history change.
SanderSpies Mar 22, 2023
825fb3a
wip: print more
SanderSpies Mar 25, 2023
8a113c9
Merge branch 'master' into sanderspies/pprint
SanderSpies May 4, 2023
4b2734a
fix build
SanderSpies May 4, 2023
0434304
Merge branch 'master' into sanderspies/pprint
SanderSpies May 4, 2023
0ac9c81
wip
SanderSpies May 4, 2023
2330afd
fix build
SanderSpies May 4, 2023
b459dbb
wip: pprint
SanderSpies May 5, 2023
9e1e253
wip
SanderSpies May 5, 2023
df0aa94
wip
SanderSpies May 5, 2023
757f219
wip
SanderSpies May 5, 2023
76f603b
wip
SanderSpies May 5, 2023
f7ef7c7
wip: improve parentheses handling
SanderSpies May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,11 @@ all-supported-ocaml-versions:

.PHONY: all-supported-ocaml-versions

pprint_test:
ocamlformat src/reason-parser/reason_pprint_ast_pprint.ml -i
dune exec src/refmt/refmt_impl.exe -- test/basicStructures.t/input.re --parse re --print ast > test/basicStructures.t/run.t.ast
dune exec src/refmt/refmt_impl.exe -- test/basicStructures.t/input.re --parse re --print re > test/basicStructures.t/run.t.new

doc:
esy dune build @doc

Expand Down
3 changes: 2 additions & 1 deletion esy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"license": "MIT",
"version": "3.8.2",
"dependencies": {
"@opam/pprint": "*",
"@opam/dune": "> 3.0.0",
"@opam/dune-build-info": "> 3.0.0",
"@opam/fix": "*",
Expand Down Expand Up @@ -48,7 +49,7 @@
"@opam/camomile", "@opam/lambda-term", "@opam/lwt", "@opam/lwt_log",
"@opam/lwt_react", "@opam/menhir", "@opam/mmap",
"@opam/ocplib-endian", "@opam/ocamlfind", "@opam/ppx_derivers",
"@opam/react", "@opam/seq", "@opam/charInfo_width",
"@opam/react", "@opam/seq", "@opam/charInfo_width", "@opam/pprint",
"@opam/utop", "@opam/zed", "ocaml"
],
"rewritePrefix": true
Expand Down
Empty file added src/reason-parser/.ocamlformat
View file
Open in desktop
Empty file.
4 changes: 3 additions & 1 deletion src/reason-parser/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@
reason_toolchain
reason_config
reason_pprint_ast
reason_pprint_ast_pprint
reason_errors
reason_parser_def
reason_parser
Expand All @@ -127,4 +128,5 @@
reason.ocaml-migrate-parsetree
menhirLib
reason.easy_format
ppxlib))
ppxlib
pprint))
Loading