-
Notifications
You must be signed in to change notification settings - Fork 99
Provider activation #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Tishka17
wants to merge
11
commits into
develop
Choose a base branch
from
feature/provider_activation
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Provider activation #561
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
419a83c
Add `when` feature
Skorpyon 202b00d
Activation check logic
Tishka17 0144f76
Simple Has test
Tishka17 74273a0
Test when, add when to provider
Tishka17 2f46aa5
Rename activator, cleanup context
Tishka17 8b72171
Add missing when, more tests
Tishka17 780da0a
Fix hanling None in component
Tishka17 9e3734a
Fix when o ndecorator
Tishka17 a3c698b
Fix space
Tishka17 be36d25
Test class based when, reformat
Tishka17 1cb2feb
Reformat
Tishka17 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| from abc import abstractmethod | ||
| from collections.abc import Callable | ||
| from typing import Any, NamedTuple, Protocol, TypeAlias | ||
|
|
||
| from dishka.entities.component import Component | ||
| from dishka.entities.key import DependencyKey | ||
|
|
||
|
|
||
| class ActivationBuilder(Protocol): | ||
| @abstractmethod | ||
| def has_active( | ||
| self, | ||
| key: DependencyKey, | ||
| request_stack: list[DependencyKey], | ||
| ) -> bool: | ||
| raise NotImplementedError | ||
|
|
||
|
|
||
| class ActivationContext(NamedTuple): | ||
| container_context: dict[Any, Any] | None | ||
| container_key: DependencyKey | ||
| key: DependencyKey | ||
| builder: ActivationBuilder | ||
| request_stack: list[DependencyKey] | ||
|
|
||
|
|
||
| Activator: TypeAlias = Callable[[ActivationContext], bool] | ||
|
|
||
|
|
||
| class Has: | ||
| def __init__( | ||
| self, | ||
| cls: Any, | ||
| *, | ||
| component: Component | None = None, | ||
| ) -> None: | ||
| self.key = DependencyKey(cls, component=component) | ||
|
|
||
| def __call__(self, ctx: ActivationContext) -> bool: | ||
| key = self.key.with_component(ctx.key.component) | ||
| if key in ctx.request_stack: # cycle | ||
| return True | ||
| return ctx.builder.has_active(key, ctx.request_stack) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.