[RFC] Global Loop (simplified) #82
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I'm in favour of this, I think it's a great step in the right direction 👍 |
|
Would the plan be to have the react libraries to start using |
|
@mbonneau i'm not sure i'd like an optional loop parameter. I'd prefer simple facade api's on top of the current api's, eg. something i proposed in #77 or @clue in reactphp-legacy/socket-client#38 and reactphp/reactphp#330 which then use the global loop. |
WyriHaximus
approved these changes
Mar 20, 2017
|
It's been 2 years since this PR was created and it seems to be approved. Are there still plans to adopt this? |
|
Closing this as it has been resolved through #226 and follow up PR's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simplified alternative to #77 introducing a global loop on top of the current API and being backward compatible.
To use the global loop,
Factory::create()can be simply replaced byGlobalLoop::get().The global loop is run automatically in a shutdown function, so no need to call
run()manually. This behaviour can be disabled by callingGlobalLoop::disableRunOnShutdown()or by simply callingGlobalLoop::get()->run().This incorporates the suggestion from @mbonneau (#77 (comment)) and also addresses #77 (comment).