Skip to content

Translation Using the Effect Hook #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 25, 2019
Merged

Conversation

sqts
Copy link
Contributor

@sqts sqts commented Feb 13, 2019

No description provided.

@sqts sqts mentioned this pull request Feb 13, 2019
88 tasks
Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Первые предложения, можно принять сразу с гитхаба.

@another-guy another-guy added the work in progress Author opened the pull-request but it's still being worked on label Feb 13, 2019
@lex111 lex111 added needs review A pull request ready to be reviewed and removed work in progress Author opened the pull-request but it's still being worked on labels Feb 14, 2019
Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Всё отлично, последние с моей стороны предложения:

@lex111 lex111 added the work in progress Author opened the pull-request but it's still being worked on label Feb 16, 2019
@lex111 lex111 removed the work in progress Author opened the pull-request but it's still being worked on label Feb 21, 2019
Copy link
Collaborator

@another-guy another-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Много комментариев по стилю и упрощению, но и страница оказалась недюжинная 💪 !

Спасибо, @Hisagr !! 💯

@@ -33,25 +33,25 @@ function Example() {
}
```

This snippet is based on the [counter example from the previous page](/docs/hooks-state.html), but we added a new feature to it: we set the document title to a custom message including the number of clicks.
Этот фрагмент основан на [примере со счётчиком из предыдущей страницы](/docs/hooks-state.html), только мы добавили новый функционал: мы изменяем заголовок документа на пользовательское сообщение, которое также содержит количество нажатий кнопки.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Этот фрагмент основан на [примере со счётчиком из предыдущей страницы](/docs/hooks-state.html), только мы добавили новый функционал: мы изменяем заголовок документа на пользовательское сообщение, которое также содержит количество нажатий кнопки.
Этот фрагмент основан на [примере со счётчиком из предыдущей страницы](/docs/hooks-state.html), только мы добавили новый функциональность: мы изменяем заголовок документа на пользовательское сообщение, которое также содержит количество нажатий кнопки.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В другом PR договорились писать именно как функционалЬНОСТЬ.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

новый -> новую тогда?

@another-guy another-guy removed their assignment Feb 22, 2019
@netlify
Copy link

netlify bot commented Feb 25, 2019

Deploy preview for ru-reactjs ready!

Built with commit 24f7a5a

https://deploy-preview-112--ru-reactjs.netlify.com

1 similar comment
@netlify
Copy link

netlify bot commented Feb 25, 2019

Deploy preview for ru-reactjs ready!

Built with commit 24f7a5a

https://deploy-preview-112--ru-reactjs.netlify.com

Copy link
Collaborator

@another-guy another-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Замечательно! Спасибо, @Hisagr !!! 💯 🎉

@another-guy another-guy added needs proofread A read-through is still needed to release the document and removed needs review A pull request ready to be reviewed labels Feb 25, 2019
@another-guy another-guy merged commit fada179 into reactjs:master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs proofread A read-through is still needed to release the document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants