Fix Attribute On Partial Reactive Property Is Duplicated #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennawatson
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #245
What is the current behavior?
#245
What is the new behavior?
This pull request introduces several changes to improve attribute handling, correct a typo in method names, and enhance the property syntax generation in the
ReactiveUI.SourceGeneratorsproject. The most important changes include refining the logic for forwarding attributes, fixing a recurring typo in theIsISchedulerTypemethod, and updating the property syntax generation to include attribute handling.Attribute handling improvements:
src/ReactiveUI.SourceGenerators.Execute/TestViewModel.cs: Added[JsonPropertyName("test")]to thePartialPropertyTestproperty to specify the JSON serialization name.src/ReactiveUI.SourceGenerators.Roslyn/Core/Extensions/ContextExtensions.cs: Updated theGetForwardedAttributesmethod to check for the[Reactive]attribute and prevent forwarding attributes without field targets when the property is reactive. [1] [2]Typo correction:
src/ReactiveUI.SourceGenerators.Roslyn/Core/Extensions/ITypeSymbolExtensions.cs: Fixed a typo in the method nameIsIShedulerType, correcting it toIsISchedulerType.src/ReactiveUI.SourceGenerators.Roslyn/ReactiveCommand/ReactiveCommandGenerator.Execute.cs: Corrected the same typo in multiple locations whereIsIShedulerTypewas used in conditional checks. [1] [2] [3]What might this PR break?
None due to build failure in previous versions
Please check if the PR fulfills these requirements
Other information: