Dragging elements in a rotated coordinate system #751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yanusa3 are you using this forked rotated coordinate system? Is it production ready? |
Yes, it's working for us already. We use it in cartography. |
|
Awesome. Thank you for this contribution!
…On Thu, 5 Sept 2024, 8:22 pm Yan Alekseenko, ***@***.***> wrote:
@yanusa3 <https://github.com/yanusa3> are you using this forked rotated
coordinate system? Is it production ready?
Yes, it's working for us already
—
Reply to this email directly, view it on GitHub
<#751 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJAYBWFPWO5DFU2MO3VKTVDZVBVZXAVCNFSM6AAAAABHMKDJDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZRHEZDINZRHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
galangel
reviewed
Feb 28, 2025
|
why not add a description to the PR? or a gif? |
Sorry, I forgot about this |
Added angle dimension
STRML
requested changes
Jun 25, 2025
| return { | ||
| node: coreData.node, | ||
| x: draggable.state.x + (coreData.deltaX / scale), |
There was a problem hiding this comment.
This is nice; however the vast majority of usage of this library will have angle: 0, and I don't want to add overhead to every user just for this edge case. Can you clean this up so the code only runs if draggable.props.angle is 0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.