Skip to content

fix: Drawer default props #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 24, 2022
Merged

fix: Drawer default props #370

merged 2 commits into from
Dec 24, 2022

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Dec 24, 2022

#363 的改动有问题,不是等效的。

<Drawer open={undefined} placement={undefined} /> 时会覆盖 default props,不等效于 <Drawer />


close ant-design/ant-design#39711
close ant-design/ant-design#39777

@vercel
Copy link

vercel bot commented Dec 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
drawer ❌ Failed (Inspect) Dec 24, 2022 at 7:37AM (UTC)

@codecov
Copy link

codecov bot commented Dec 24, 2022

Codecov Report

Merging #370 (985c5f7) into master (023b7e3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #370   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          112       119    +7     
  Branches        37        45    +8     
=========================================
+ Hits           112       119    +7     
Impacted Files Coverage Δ
src/Drawer.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@afc163 afc163 merged commit e534376 into master Dec 24, 2022
@afc163 afc163 deleted the fix/Drawer-defaultProps branch December 24, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drawer component is broken in 5.1.0 Drawer组件无法关闭
1 participant