Improvements and refactoring for preprocessing and MCMC #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
May need to be undone later, but good enough for now
There were multiple issues (enumerated below). Fortunately, they approximately canceled, so it only slightly moves the central value and slightly increases the size of the posterior. The issues fixed were: - We should have been reporting the quark qhat rather than the gluon qhat by convention - There was an issue with passing the wrong alpha_s to the running_alpha_s calculation
Also noted in previous commits (f7a55ed), but better to try to make it easy to find the relevant information
Since we want it to be standalone, it's best if there's fewer imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.