Expose max snapshots environment variable #2193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
davidcassany
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
LGTM
Just one thing, I believe we could add a check to test the MAX_SNAPS variable here. This way we make sure the custom unmarshal is tested.
Signed-off-by: Andrea Mazzotti <[email protected]>
davidcassany
pushed a commit
to davidcassany/elemental-toolkit
that referenced
this pull request
Oct 1, 2024
* Expose SNAPSHOTTER_MAX_SNAPS run variable Signed-off-by: Andrea Mazzotti <[email protected]> (cherry picked from commit 98ade87)
davidcassany
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Expose SNAPSHOTTER_MAX_SNAPS run variable Signed-off-by: Andrea Mazzotti <[email protected]> (cherry picked from commit 98ade87)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little change to expose the MAX_SNAPS as environment variable.
This will be exploited by the
elemental-registerduring install.