Skip to content

Remove reference to AS::Concern from the codebase #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amatsuda merged 1 commit into from
Nov 25, 2020
Merged

Remove reference to AS::Concern from the codebase #88

amatsuda merged 1 commit into from
Nov 25, 2020

Conversation

@amatsuda
Copy link
Member

@amatsuda amatsuda commented Nov 25, 2020

We can just safely get rid of require and extend AS::Concern from the whole codebase since these modules do never use (have never used) any ActiveSupport::Concern feature.

kaspth
kaspth approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@kaspth kaspth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

@amatsuda amatsuda merged commit 561787e into rails:master Nov 25, 2020
@amatsuda amatsuda deleted the rm_as_concern branch November 25, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kaspth kaspth kaspth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amatsuda @kaspth