Skip to content

Conversation

@heka1024
Copy link
Contributor

@heka1024 heka1024 commented May 27, 2024

In my application, I want all select query from GlobalID::Locator to come from the read only database, but I can't modify the DEFAULT_LOCATOR, so I made it configurable. I think it's more in line with the Rails philosophy to make this customizable, not just for my use case.

Any feedback or suggestions would be greatly appreciated!

@heka1024 heka1024 changed the title Make default_locator as configurable Make DEFAULT_LOCATOR Configurable May 27, 2024
@heka1024
Copy link
Contributor Author

Because every version of railties depends on Ruby >= 3.1.0
  and rails_main.gemfile depends on railties >= 0,
  Ruby >= 3.1.0 is required.
So, because current Ruby version is = 2.7.8,
  version solving has failed.

There are some unrelated CI issues that should be handled in a separate PR. I'll take care of them when I have time.

@heka1024
Copy link
Contributor Author

Hi, @rafaelfranca. Could you give me a feedback when you have a time?

@olleolleolle
Copy link
Contributor

@heka1024 I think you can rebase these changes, and tests may all pass?

@heka1024 heka1024 force-pushed the configurable-base-locator branch from 6966d15 to 5ed7420 Compare August 24, 2024 13:15
@heka1024
Copy link
Contributor Author

heka1024 commented Aug 24, 2024

@olleolleolle All tests are passing now. Appreciate the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants