General modernization of some errors; better handling of HTML error #255
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,86 +1,124 @@ | ||
| # Resource exhausted (Sheets, ReadGroup) | ||
|
|
||
| Code | ||
| response_process(resp) | ||
| Condition | ||
| Error in `expect_recorded_error()`: | ||
| ! Client error: (429) RESOURCE_EXHAUSTED | ||
| * Either out of resource quota or reaching rate limiting. The client should look for google.rpc.QuotaFailure error detail for more information. | ||
| * Quota exceeded for quota metric 'Read requests' and limit 'Read requests per minute per user' of service 'sheets.googleapis.com' for consumer 'project_number:603366585132'. | ||
| Error details: | ||
| * reason: RATE_LIMIT_EXCEEDED | ||
| * domain: googleapis.com | ||
| * metadata.quota_location: global | ||
| * metadata.quota_metric: sheets.googleapis.com/read_requests | ||
| * metadata.quota_limit: ReadRequestsPerMinutePerUser | ||
| * metadata.quota_limit_value: 60 | ||
| * metadata.consumer: projects/603366585132 | ||
| * metadata.service: sheets.googleapis.com | ||
| Links | ||
| * Description: Request a higher quota limit. | ||
| URL: https://cloud.google.com/docs/quota#requesting_higher_quota | ||
|
|
||
| # Request for non-existent resource (Drive) | ||
|
|
||
| Code | ||
| response_process(resp) | ||
| Condition | ||
| Error in `expect_recorded_error()`: | ||
| ! Client error: (404) Not Found | ||
| File not found: NOPE_NOT_A_GOOD_ID. | ||
| * domain: global | ||
| * reason: notFound | ||
| * message: File not found: NOPE_NOT_A_GOOD_ID. | ||
| * locationType: parameter | ||
| * location: fileId | ||
|
|
||
| # Request for which we don't have scope (Fitness) | ||
|
|
||
| Code | ||
| response_process(resp) | ||
| Condition | ||
| Error in `expect_recorded_error()`: | ||
| ! Client error: (403) Forbidden | ||
| Request had insufficient authentication scopes. | ||
| PERMISSION_DENIED | ||
| * message: Insufficient Permission | ||
| * domain: global | ||
| * reason: insufficientPermissions | ||
|
|
||
| # Use key that's not enabled for the API (Sheets) | ||
|
|
||
| Code | ||
| response_process(resp) | ||
| Condition | ||
| Error in `expect_recorded_error()`: | ||
| ! Client error: (403) PERMISSION_DENIED | ||
| * Client does not have sufficient permission. This can happen because the OAuth token does not have the right scopes, the client doesn't have permission, or the API has not been enabled for the client project. | ||
| * Google Sheets API has not been used in project 977449744253 before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/sheets.googleapis.com/overview?project=977449744253 then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry. | ||
| Error details: | ||
| Links | ||
| * Description: Google developers console API activation | ||
| URL: https://console.developers.google.com/apis/api/sheets.googleapis.com/overview?project=977449744253 | ||
| * reason: SERVICE_DISABLED | ||
| * domain: googleapis.com | ||
| * metadata.consumer: projects/977449744253 | ||
| * metadata.service: sheets.googleapis.com | ||
|
|
||
| # Request with invalid argument (Sheets, bad range) | ||
|
|
||
| Code | ||
| response_process(resp) | ||
| Condition | ||
| Error in `expect_recorded_error()`: | ||
| ! Client error: (400) INVALID_ARGUMENT | ||
| * Client specified an invalid argument. Check error message and error details for more information. | ||
| * Unable to parse range: NOPE!A5:F15 | ||
|
|
||
| # Request with bad field mask (Sheets) | ||
|
|
||
| Code | ||
| response_process(resp) | ||
| Condition | ||
| Error in `expect_recorded_error()`: | ||
| ! Client error: (400) INVALID_ARGUMENT | ||
| * Client specified an invalid argument. Check error message and error details for more information. | ||
| * Request contains an invalid argument. | ||
| Error details: | ||
| Field violations | ||
| * Field: sheets.sheetProperties | ||
| Description: Error expanding 'fields' parameter. Cannot find matching fields for path 'sheets.sheetProperties'. | ||
|
|
||
| # Request for nonexistent resource (Sheets) | ||
|
|
||
| Code | ||
| response_process(resp) | ||
| Condition | ||
| Error in `expect_recorded_error()`: | ||
| ! Client error: (404) NOT_FOUND | ||
| * A specified resource is not found, or the request is rejected by undisclosed reasons, such as whitelisting. | ||
| * Requested entity was not found. | ||
|
|
||
| # Request with invalid value (tokeninfo, stale token) | ||
|
|
||
| Code | ||
| response_process(resp) | ||
| Condition | ||
| Error in `expect_recorded_error()`: | ||
| ! Client error: (400) Bad Request | ||
| * Invalid Value | ||
|
|
||
| # Request to bad URL (tokeninfo, HTML content) | ||
|
|
||
| Code | ||
| response_process(resp) | ||
| Condition | ||
| Error in `expect_recorded_error()`: | ||
| ! Client error: (404) Not Found | ||
| x Expected content type 'application/json', not 'text/html'. | ||
| i See 'VOLATILE_FILE_PATH' for the html error content. | ||
| i Or execute `browseURL("VOLATILE_FILE_PATH")` to view it in your browser. | ||
|
Comment on lines
+160
to
+163
Member
Author
There was a problem hiding this comment. This is a look at the new handling for an error that comes as html. In certain contexts, such as RStudio, the "See 'VOLATILE_FILE_PATH' ..." is a clickable link to open the file. I can't make the https://cli.r-lib.org/reference/links.html#security-considerations |
||
|
|
||
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this is where the
Could not parse cli{}expression: ...error was coming from (#254). When thecontentis html, it can contain curly braces (and, indeed, in this case, did), which then confuses cli when it processes the error message bullets.There is a solution, which is to refer to the
{-and-}-containing string from a template:https://cli.r-lib.org/reference/inline-markup.html#escaping-and-
However, I decided not to do that, but instead to make it much easier to see the full html. Previously, my only direct experience of html errors was from the token info endpoints, which seemed rather obscure and the examples I knew about produced a relatively small amount of html, so it seemed sensible to show a part (and maybe all) of the html in the actual error message.
But the error seen in #254 is actually important for the user (429 too many requests, from googledrive) and involved considerably more html (so a wee little excerpt didn't reveal anything useful).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pitfall is also exactly described here:
https://rlang.r-lib.org/reference/topic-condition-formatting.html#transitioning-from-abort-to-cli-abort-