Skip to content

Increasing timeout from 0.8 to 2 #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
downloaderfan wants to merge 2 commits into from
Closed

Increasing timeout from 0.8 to 2 #195

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fff4eb1
Increasing timeout from 0.8 to 2
downloaderfan Nov 2, 2021
2573204
Conditional timeout for GCP
downloaderfan Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/credentials_gce.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ gce_metadata_request <- function(path, stop_on_error = TRUE) {
path <- substring(path, 2)
}
url <- paste0(root_url, "computeMetadata/v1/", path)
timeout <- getOption("gargle.gce.timeout", default = 0.8)
timeout <- getOption("gargle.gce.timeout", default = ifelse(!detect_gce(), 0.8, 2))
Copy link
Member

@jennybc jennybc Nov 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would seem to create a recursive call to gce_metadata_request().

Now that we seem to be converging on the right solution, I plan to make a PR that implements it.

Copy link
Author

@downloaderfan downloaderfan Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jennybc Alright, thanks :)

response <- try({
httr::with_config(httr::timeout(timeout), {
httr::GET(url, httr::add_headers("Metadata-Flavor" = "Google"))
Expand Down