Skip to content

Conversation

@jcheng5
Copy link
Member

@jcheng5 jcheng5 commented Oct 30, 2020

Closes #94

To repro, create a new OAuth client ID, and for "Application type", choose "web". If you download the secrets JSON file for this, you'll see that the key is called "web" instead of "installed".

@jennybc
Copy link
Member

jennybc commented Oct 31, 2020

Do you have the ability to merge? If not, do you want that, for now and future?

@jennybc
Copy link
Member

jennybc commented Oct 31, 2020

Ah, I think you must, because this is coming from an internal branch.

Co-authored-by: Jennifer (Jenny) Bryan <[email protected]>
@jcheng5 jcheng5 merged commit 8db62ab into master Oct 31, 2020
@jennybc jennybc deleted the client_secret_web branch October 21, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

oauth_app_from_json() does not read web based client JSON

3 participants