trafos handling DLV #919
Merged
trafos handling DLV #919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 6 files 6 suites 7m 19s ⏱️ Results for commit f7c3c2b. ♻️ This comment has been updated with latest results. |
shumpohl
reviewed
Aug 1, 2025
qupulse/program/transformation.py
Outdated
|
|
||
|
|
||
| @property | ||
| def contains_sweepval(self) -> bool: |
Member
There was a problem hiding this comment.
Would it be a great churn to rename this to contains_dynamic_value and make it a method instead of a property?
Collaborator
Author
There was a problem hiding this comment.
should be no problem.
what is the benefit here of a method over property?
shumpohl
requested changes
Aug 1, 2025
Member
shumpohl
left a comment
shumpohl
left a comment
There was a problem hiding this comment.
Discuss replacement of sweepval with dynamic_value
shumpohl
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.