Jvm performance benchmarks rest wrapper #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using https://github.com/ionutbalosin/jvm-performance-benchmarks/
This PR also removes the hardcoded url on the drivers and includes a urls.txt file on the test suites that are used to run the oha tests instead. That urls.txt contains relative urls, so the driver can add the hostname (and protocol) to those urls.
OHA uses a random strategy to choose which url from the file to request. In the case of the sqpc tests, the urls.txt file only contains one url (
/fruits), so all requests go there, as when the url was hardcoded.This also allows other future drivers to use that file instead of hardcoding urls.
The new benchmark test is still a bit dumb (only uses a couple of simple benchmarks) and makes use of different urls on the urls.txt file to simulate a more "realistic" test (still doubting if this is a good idea, but we can simplify the urls.txt later, or even create different strategies to use different urls).
Also added a timeout of 10s to oha driver, because when testing weird stuff, it got stuck forever waiting for a response that would never arrive. This is a test code problem, but we don't want to get hung out forever anyway.