-
-
Notifications
You must be signed in to change notification settings - Fork 508
refactor(quinn-udp): extract decode_cmsg helper
#2469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
djc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits, but this looks nice!
12be3ae to
f8da1f7
Compare
djc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
|
@mxinden do you have time to take a look at this Android stuff? Seems like it's not working quite right. |
|
Looks like it is running out of disk space?
|
Extract control message decoding logic into dedicated helper functions.
This refactoring prepares the codebase for future work that will make
decode_recvgeneric over theMsgHdrtrait, enabling shared decoding logic betweenlibc::msghdrandmsghdr_xmessage types.Broken out of #2463 as suggested by @djc.