Skip to content

Conversation

@larseggert
Copy link
Contributor

Extract control message decoding logic into dedicated helper functions.

This refactoring prepares the codebase for future work that will make decode_recv generic over the MsgHdr trait, enabling shared decoding logic between libc::msghdr and msghdr_x message types.

Broken out of #2463 as suggested by @djc.

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, but this looks nice!

@larseggert larseggert force-pushed the refactor/decode-cmsg-helper branch from 12be3ae to f8da1f7 Compare December 9, 2025 14:09
@larseggert larseggert requested a review from djc December 9, 2025 14:09
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@djc
Copy link
Member

djc commented Dec 10, 2025

@mxinden do you have time to take a look at this Android stuff? Seems like it's not working quite right.

@thomaseizinger
Copy link
Contributor

Looks like it is running out of disk space?

FATAL | Not enough space to create userdata partition. Available: 7322.52 MB at /home/runner/.android/avd/test.avd, need 7372.80 MB.

https://github.com/quinn-rs/quinn/actions/runs/20066369574/job/57649369733?pr=2469#step:12:107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants