feat: Add case_insensitive param to some Elastic DSL queries #6005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trinity-1686a
approved these changes
Dec 3, 2025
Contributor
trinity-1686a
left a comment
trinity-1686a
left a comment
There was a problem hiding this comment.
lgtm. can you fix the formatting issue before i merge?
rdettai-sk
force-pushed
the
feat/elastic_dsl_case_insensitive
branch
from
4821ff8 to
92be2de
Compare
auto-merge was automatically disabled
December 8, 2025 08:28
Head branch was pushed to by a user without write access
Darkheir
force-pushed
the
feat/elastic_dsl_case_insensitive
branch
from
92be2de to
df286ef
Compare
Signed-off-by: Darkheir <[email protected]>
Signed-off-by: Darkheir <[email protected]>
Darkheir
force-pushed
the
feat/elastic_dsl_case_insensitive
branch
from
df286ef to
2f68622
Compare
PSeitz-dd
pushed a commit
that referenced
this pull request
Dec 10, 2025
* feat: Add case_insensitive param to some Elastic DSL queries Signed-off-by: Darkheir <[email protected]> * Apply PR review sugestion Signed-off-by: Darkheir <[email protected]> --------- Signed-off-by: Darkheir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for the
case_insensitiveparameter for some elasticsearch DSL queries:To support case insensitive search on regex based ASTs a mode modifier
(?i), is added at the beginning of the regex string.For term queries this PR fallback to using a
RegexQueryAST whencase_insensitiveis set to True.It seems that elasticsearch uses a case insensitive Lucene automaton to cover this case.
How was this PR tested?
Added integration tests