Upgrade Warp #5870
Merged
Upgrade Warp #5870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
reviewed
Sep 3, 2025
Abdul-Andha
commented
Sep 8, 2025
| @@ -570,27 +571,35 @@ async fn search_stream_endpoint( | |||
| .unwrap_or_else(|_| HeaderValue::from_static("Search stream error")); | |||
| let mut trailers = HeaderMap::new(); | |||
| trailers.insert("X-Stream-Error", header_value); | |||
| let _ = sender.send_trailers(trailers).await; | |||
| sender.abort(); | |||
| // let _ = tx.send_trailers(trailers).await; | |||
There was a problem hiding this comment.
i commented this out because mpsc::channel does not have send_trailers. Do we need this?
There was a problem hiding this comment.
I've just discovered http_body_util::channel::Channel::new(); (behind the channel feature). I have a feeling we can use that and it'll work nicely.
guilload
reviewed
Sep 8, 2025
quickwit/Cargo.toml
Outdated
| @@ -123,17 +123,17 @@ hex = "0.4" | |||
| home = "0.5" | |||
| hostname = "0.3" | |||
| http = "1.3" | |||
| http-body = "1.0" | |||
| http-body-util = "0.1.3" | |||
There was a problem hiding this comment.
While we're at it.
Suggested change
| http-body-util = "0.1.3" | |
| http-body-util = "0.1" |
| @@ -570,27 +571,35 @@ async fn search_stream_endpoint( | |||
| .unwrap_or_else(|_| HeaderValue::from_static("Search stream error")); | |||
| let mut trailers = HeaderMap::new(); | |||
| trailers.insert("X-Stream-Error", header_value); | |||
| let _ = sender.send_trailers(trailers).await; | |||
| sender.abort(); | |||
| // let _ = tx.send_trailers(trailers).await; | |||
There was a problem hiding this comment.
I've just discovered http_body_util::channel::Channel::new(); (behind the channel feature). I have a feeling we can use that and it'll work nicely.
|
PR is blocked by this issue. Warp does not allow returning streams or other custom body types. This is needed for search stream endpoint in |
Abdul-Andha
force-pushed
the
abdul.andha/upgrade-warp
branch
from
9b3e032 to
b9db83b
Compare
guilload
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How was this PR tested?
make test-all