Skip to content

Conversation

@Guts
Copy link
Collaborator

@Guts Guts commented Sep 4, 2024

This PR follows up:

It improve how system's store certificates are used, preferring a custom HTTP adapter to the SSL injection.

It's mainly inspired from https://stackoverflow.com/a/78265028/2556577.

@Guts Guts added this to the 0.35.2 milestone Sep 4, 2024
@Guts Guts self-assigned this Sep 4, 2024
@github-actions github-actions bot added enhancement New feature or request quality Tests, project resiliency, etc. labels Sep 4, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2024

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.55%. Comparing base (e845838) to head (6294252).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
qgis_deployment_toolbelt/utils/file_downloader.py 44.44% 4 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
- Coverage   70.55%   70.55%   -0.01%     
==========================================
  Files          47       47              
  Lines        3118     3124       +6     
  Branches      669      669              
==========================================
+ Hits         2200     2204       +4     
- Misses        724      726       +2     
  Partials      194      194              
Flag Coverage Δ
unittests 69.97% <44.44%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
qgis_deployment_toolbelt/utils/file_downloader.py 72.13% <44.44%> (-0.60%) ⬇️

@Guts Guts merged commit 19a64fa into main Sep 4, 2024
@Guts Guts deleted the improve/ssl-trust-local-store-transport-adapter branch September 4, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request quality Tests, project resiliency, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants