This repository was archived by the owner on May 17, 2022. It is now read-only.
fix: Fix test with new opencontrol version #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abenseny
approved these changes
Nov 26, 2021
I think it's fine not to update them for now. I'll try to see if we can have a broader discussion with product about the future of these packages. |
Jacqueslee
reviewed
Nov 26, 2021
There was a problem hiding this comment.
thanks @tachikoma-li ! agreed with Leo to have a follow-up discussion on how opencontrol fit into the broad product offering and how much effort needed to keep it up to date.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code and tests should be working with the latest version of open control now.
However, note that the qisikt-related pkgs are all locked to some very old versions:
qiskit-terra (0.12.0)(latest is 0.18.3) doesn't support Python 3.9.qiskit-ibmq-provideris 0.3.3 and latest is 0.18.1.Updating to the latest version would require more change to the actual code, not just the test.
I am not sure if we want to do it. Any thought? @Jacqueslee @leoadec