Skip to content

Conversation

@duilio
Copy link
Contributor

@duilio duilio commented Aug 29, 2023

map restores an instance of a Trie from memory.

@duilio
Copy link
Contributor Author

duilio commented Aug 29, 2023

I've just realized the test suite doesn't run against Python 2.x, I've only added the PY2 compat code for the buffer protocol because I saw the Python 2 classifier in setup.py, I guess it would be better to remove the compat code and the classifier which is there probably for legacy reasons?

@BoboTiG
Copy link
Member

BoboTiG commented Aug 30, 2023

You are right, it's time to say goodbye to Python 2.

Do you think you can do it in a separate PR (if you was thinking about doing it yourself, of course)? I'll do it :)

@BoboTiG
Copy link
Member

BoboTiG commented Aug 30, 2023

OK that's done in #91. If you can rebase your branch then, I'll unlock the CI.

@duilio
Copy link
Contributor Author

duilio commented Aug 31, 2023

@BoboTiG branch rebased. ;-)

@BoboTiG BoboTiG merged commit b8519d8 into pytries:master Aug 31, 2023
@BoboTiG
Copy link
Member

BoboTiG commented Aug 31, 2023

Thanks a lot @duilio 🍾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants