add a vision_collate function that honours prototype features #6680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
changed the title
pmeier
commented
Oct 3, 2022
|
|
||
| vision_collate_fn_map = { | ||
| (Image, Mask, Label, OneHotLabel): new_like_collate_fn, | ||
| type(None): no_collate_fn, |
There was a problem hiding this comment.
We need this for #5233.
| @@ -0,0 +1,29 @@ | |||
| from typing import Any, Callable, Dict, Optional, Sequence, Tuple, Type, Union | |||
There was a problem hiding this comment.
I've put this into features for now, put when everything is rolled out it should probably be in datasets.
ejguan
approved these changes
Oct 3, 2022
datumbox
suggested changes
Oct 3, 2022
There was a problem hiding this comment.
Ideally we should avoid adding collate methods directly in TorchVision. One option is to keep it on the references. That's something that we plan to discuss with @pmeier once he is back from PTO. The discussion can go either way so, everything is on the table.
I'm going to mark the PR with "request changes" to avoid accidental merges (since 1 approval = merge). After we sync with Philip, we can unblock this. 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6433 (comment). I've intentionally left out the collation function, since we just use
vision/references/detection/utils.py
Lines 203 to 204 in 07ae61b
which is completely separated from
default_collate. We might provide it publicly later on as well.