-
Notifications
You must be signed in to change notification settings - Fork 701
[Image] Add support for PPM images. #5559
[Image] Add support for PPM images. #5559
Conversation
|
@yinghai, @zrphercule, attempt #2. |
|
@zrphercule has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
zrphercule
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
@zrphercule merged this pull request in fceb6a1. |
|
@aturetsk Unfortunately this breaks Glow's CI once again: https://app.circleci.com/pipelines/github/pytorch/glow/13053/workflows/7b93ef9f-150a-410c-a7ac-3a12954934d0/jobs/95511 We will revert this pr again and wait for your fix... |
|
Hi @zrphercule, |
Agree, this is very weird. I will land the revert, and could you please submit this diff once again? I would like to check why it is not imported to phabricator. Thanks! |
|
This pull request has been reverted by 7f83c03. |
Summary:
Add support for PPM images as input for models.
Documentation:
N/A
Test Plan:
Added an ImageTest unit test.