This repository was archived by the owner on Jul 1, 2025. It is now read-only.
Add numerical equivalence check to GraphOptz.nopRelu test case. #3581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@SplitInfinity merged this pull request in a0d7352. |
vdantu
pushed a commit
to vdantu/glow
that referenced
this pull request
Jul 12, 2020
…rch#3581) Summary: Added a numerical equivalence check to this test case which checks that both the original and optimized graph return the same result for the same input. Fixes T54749244 Pull Request resolved: pytorch#3581 Test Plan: => ctest -R GraphOptz Test project /Users/lofe/git/glow/build_Debug Start 8: GraphOptzTest 1/1 Test pytorch#8: GraphOptzTest .................... Passed 0.09 sec 100% tests passed, 0 tests failed out of 1 Total Test time (real) = 0.10 sec Differential Revision: D17702016 Pulled By: SplitInfinity fbshipit-source-id: 809aad9ddbb5caa10809cbc83ab0871511add015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added a numerical equivalence check to this test case which checks that both the original and optimized graph return the same result for the same input.
Fixes T54749244
Test Plan:
=> ctest -R GraphOptz
Test project /Users/lofe/git/glow/build_Debug
Start 8: GraphOptzTest
1/1 Test #8: GraphOptzTest .................... Passed 0.09 sec
100% tests passed, 0 tests failed out of 1
Total Test time (real) = 0.10 sec