Skip to content
This repository was archived by the owner on Jul 1, 2025. It is now read-only.

Conversation

@arunm-git
Copy link
Contributor

Description:

This commit brings over changes that were made internally at FB for glow-h.

  • Most of the changes are in lib/Backends/Habana/* and are just replaying changes made internally. Hopefully reviewing those should be easy enough for @bertmaher or @rdzhabarov who made most of those changes.
  • DeviceManagerTest changes are to parameterize by backend kind
  • HabanaBackendTest change adds one test case which is currently disabled.

Testing:
ninja all && ninja test
Habana specific testing will be done internally.

Copy link
Contributor

@rdzhabarov rdzhabarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go 🚢

@rdzhabarov
Copy link
Contributor

can you check the test failure:

../lib/Backends/OpenCL/OpenCL.cpp:168: failed assertion `kernel && "clCreateKernel Failed."'

does not look like just a spurious failure.

*Description*:

This commit brings over changes that were made internally at FB for glow-h.

*Testing*:
ninja all && ninja test
Habana specific testing will be done internally.
@arunm-git arunm-git merged commit d67cfad into pytorch:master May 2, 2019
@arunm-git arunm-git deleted the H-deltas branch May 2, 2019 02:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants