-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Make Mapping/MutableMapping params positional-only #5772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These are positional-only on dict, so it makes sense to mark them as positional-only in these base classes too. Fixes #5771
Lots of stubtest complaints about incompatible overrides and runtime inconsistencies. Marking as draft until I resolve those. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
@JelleZijlstra this caused this regression: python/mypy#11831 Maybe we can do it other way around? Restore named args in |
#6694 does that but I think it's the wrong solution; we can discuss there. (Though note that I'll have limited availability for the next two weeks.) |
These are positional-only on dict, so it makes sense to mark them as positional-only in these base classes too.
Fixes #5771