Skip to content

Update turtle to 3.12 #10548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Update turtle to 3.12 #10548

merged 4 commits into from
Aug 10, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Aug 9, 2023

@github-actions

This comment has been minimized.

@AlexWaygood
Copy link
Member

Oh, stubtest is failing for the one in the global scope. Can't immediately see why, though.

@sobolevn
Copy link
Member Author

sobolevn commented Aug 9, 2023

Because turtle uses some magic in _make_global_funcs, I am trying to figure out if this is correct.

@sobolevn
Copy link
Member Author

sobolevn commented Aug 9, 2023

I find missing default and kw-only translated into positional-or-keyword as problems. I will report a bug to cpython.

@AlexWaygood
Copy link
Member

Why don't you revert the global-namespace teleport changes for now, until the CPython change is fixed? Then we can merge this now, and deal with the last remaining change later

@sobolevn
Copy link
Member Author

Sure!

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit 19ed22e into main Aug 10, 2023
@AlexWaygood AlexWaygood deleted the py312-turtle branch August 10, 2023 10:44
@AlexWaygood
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants