Skip to content

Fix handling of non-method callable attribute #3227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

Fix handling of non-method callable attribute #3227

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
5800819
reverse the subtyping test, more explicit error message, unify cases
elazarg Apr 23, 2017
a67b78c
reverse the direction of type fallback, avoid tuple fallback
elazarg Apr 23, 2017
a523b1f
lint
elazarg Apr 23, 2017
78d0887
check access to reversed methods only per-item
elazarg Apr 23, 2017
3c8e85f
comment
elazarg Apr 23, 2017
42020fb
Merge branch 'master' into fix-property-selftype
elazarg Jul 4, 2017
7aacb4f
Merge branch 'master' into fix-property-selftype
elazarg Jul 20, 2017
6703816
rephrase error message, use union_items
elazarg Jul 25, 2017
d7a41f9
add test with an unbound typevar
elazarg Jul 25, 2017
1c58d49
Use TypeType.make_normalized
elazarg Jul 25, 2017
8c4a8ce
Merge branch 'master' into fix-property-selftype
elazarg Aug 16, 2017
499d596
Merge remote-tracking branch 'upstream/master' into fix-property-self…
elazarg Sep 24, 2017
71faee9
add docstrings and comments
elazarg Sep 24, 2017
2108a03
revert uncalled-for fix
elazarg Sep 24, 2017
a8a0386
use meet to simulate dispatch; cleanup
elazarg Sep 26, 2017
bd1f0f3
better phrasing
elazarg Sep 26, 2017
733fd8e
assert instead of cast; iterate over union
elazarg Sep 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mypy/checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,6 +796,7 @@ def check_reverse_op_method(self, defn: FuncItem, typ: CallableType,
arg_types = list(arg_type.iter_deep())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use union_items() instead of iter_deep().

else:
return
# We check that each method is fine when dispatched on a proper self argument
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI you can make your local commit history more relevant by using git commit --amend for such things (since you did not push to GitHub in between).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand I should put more info in the commit messages, but this comment is needed regardless. Or are you referring to the code below it?

Copy link
Member

@gvanrossum gvanrossum Apr 24, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither. I meant that I would prefer to see a single commit pushed to the PR that included the previous commit plus this one (which just added a comment that you forgot on the previous commit).

You can do that locally by using git commit --amend for the second commit (that adds the comment). You could also do this after the fact using git rebase -i.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is unclear. Can you improve it?

for arg_type in arg_types:
typ2 = self.expr_checker.analyze_external_member_access(
other_method, arg_type, defn)
Expand Down