get_class_decorator_hook_2: fix fullname #16063
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikonst
commented
Sep 7, 2023
Comment on lines
1828
to
+1830
| if isinstance(expr, CallExpr): | ||
| return self.get_fullname_for_hook(expr.callee) | ||
| elif isinstance(expr, IndexExpr): | ||
| expr = expr.callee | ||
| if isinstance(expr, IndexExpr): |
There was a problem hiding this comment.
The culprit - see testClassDecoratorHook2_incorrect for repro.
Basically, if we have
@my_decorator()()
^^^^^^^^^^^^^^^^
then I feel we ought to use the whole callable, and not recurse in, but maybe I'm missing some use case?
|
cc @JukkaL re |
ikonst
force-pushed
the
fix-get_class_decorator_hook_2
branch
from
501b2dd to
6bcf3f2
Compare
This comment has been minimized.
This comment has been minimized.
|
The syntax errors you're getting on Python 3.8 are likely because PEP 614 was first implemented in Python 3.9 |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
sobolevn
reviewed
Sep 17, 2023
| def my_decorator(t: Any) -> Any: | ||
| raise | ||
|
|
||
| @my_decorator()() |
There was a problem hiding this comment.
What will happen for @my_decorator(1)()?
ilevkivskyi
approved these changes
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16062.