Fix: Mac/Extras.install.py，Can not filter osx .DS_store file #98579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
The following commit authors need to sign the Contributor License Agreement: Click the button to sign: |
arhadthedev
reviewed
Oct 24, 2022
Comment on lines
12
to
16
| if name == 'CVS': return 0 | ||
| if name == '.cvsignore': return 0 | ||
| if name == '.DS_store': return 0 | ||
| if name == '.DS_Store': return 0 | ||
| if name == '.svn': return 0 |
There was a problem hiding this comment.
Suggested change
| if name == 'CVS': return 0 | |
| if name == '.cvsignore': return 0 | |
| if name == '.DS_store': return 0 | |
| if name == '.DS_Store': return 0 | |
| if name == '.svn': return 0 | |
| if name in ('CVS', '.cvsignore', '.DS_store', '.DS_Store', '.svn')`: | |
| return 0 |
A proof-of-concept:
>>> def test(name):
... return name in ('CVS', '.cvsignore', '.DS_store', '.DS_Store', '.svn')
...
>>> test('fooCVS')
False
>>> test('foo')
False
>>> test('CVS')
TrueThere was a problem hiding this comment.
simple and better performance
|
Sorry , I use a wrong email, cannot sign Contributor License Agreement @arhadthedev I'll create a new PR |
|
For history: the new PR is gh-98580. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac/Extras.install.py，Can not filter osx DS_store file
As
But in OSX, Real File Name is
.DS_Store, like this(venv) zhangbo@zhangbodeMacBook-Pro a2 % ll -a total 16 drwxr-xr-x 4 zhangbo staff 128 Oct 22 17:34 . drwxr-xr-x 8 zhangbo staff 256 Oct 22 17:18 .. -rw-r--r--@ 1 zhangbo staff 6148 Oct 22 17:17 .DS_Store drwxr-xr-x 3 zhangbo staff 96 Oct 22 17:23 123So we need update
.DS_storeto.DS_Store