Skip to content

bpo-43979: Remove unnecessary operation from urllib.parse.parse_qsl #25756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2021
Merged

bpo-43979: Remove unnecessary operation from urllib.parse.parse_qsl #25756

merged 2 commits into from
Apr 30, 2021

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Apr 30, 2021 •
edited by miss-islington
Loading

https://bugs.python.org/issue43979

Automerge-Triggered-By: GH:gpshead

@corona10 corona10 requested a review from gpshead April 30, 2021 16:38
@corona10
Copy link
Member Author

corona10 commented Apr 30, 2021 •
edited
Loading

Creating pairs is legacy from pairs = [s2 for s1 in qs.split('&') for s2 in s1.split(';')].
Since filtering logic is removed, this list comprehension does not need anymore.

But I hope this PR would not be merged until the main(master) branch is updated to 3.11 since Python 3.10 will be released soon.
Once the PR is approved, I am going to merge this PR if the main(master) branch is updated to 3.11

@corona10 corona10 closed this Apr 30, 2021
@corona10 corona10 deleted the bpo-43979 branch April 30, 2021 17:59
@corona10 corona10 restored the bpo-43979 branch April 30, 2021 18:18
@corona10 corona10 reopened this Apr 30, 2021
@gpshead gpshead added the performance Performance or resource usage label Apr 30, 2021
gpshead
gpshead approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfectly fine for 3.10, even during the beta cycle. It's an obvious logically equal code cleanup.

@corona10
Copy link
Member Author

This is perfectly fine for 3.10, even during the beta cycle. It's an obvious logically equal code cleanup.

Okay, let's merge it :)

@gpshead gpshead self-assigned this Apr 30, 2021
@miss-islington
Copy link
Contributor

@corona10: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 6143fcd into python:master Apr 30, 2021
@corona10 corona10 deleted the bpo-43979 branch May 1, 2021 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

@gpshead gpshead

Labels
performance Performance or resource usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@corona10 @miss-islington @gpshead @the-knights-who-say-ni @bedevere-bot