Skip to content

Deleted extra line #19834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Deleted extra line #19834

wants to merge 1 commit into from

Conversation

kenplix
Copy link

@kenplix kenplix commented May 1, 2020

In 3.8 Python, multiprocessing does not work because the module signal is empty

My solution is:
in signal/init.py add line
from _signal import *

In 3.8 Python,  multiprocessing does not work because the module signal is empty

My solution is:
in signal/__init__.py add line 
from _signal import *
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@AleksandrTolstoy

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change breaks all CI. It is wrong.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@vstinner
Copy link
Member

vstinner commented May 1, 2020

I don't understand which issue you are trying to solve.

@csabella
Copy link
Contributor

csabella commented May 28, 2020

This is from an 'unknown repository' and the CLA hasn't been signed, so it may have been submitted by accident. As such, I'm going to close this PR.

@csabella csabella closed this May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants