Skip to content

bpo-40462: fix variable and function names #19832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2020
Merged

bpo-40462: fix variable and function names #19832

merged 1 commit into from
May 1, 2020

Conversation

furkanonder
Copy link
Contributor

@furkanonder furkanonder commented May 1, 2020

@vstinner
Copy link
Member

vstinner commented May 1, 2020

Hum, the bot which checks the CLA didn't add the label. I reported the issue at: python/core-workflow#366

I checked manually: @furkanonder signed the CLA: https://bugs.python.org/user34066

I'm also curious why Windows and macOS GitHub action jobs didn't start on this PR? python/core-workflow#367

@vstinner
Copy link
Member

vstinner commented May 1, 2020

I close/reopen the PR to attempt to workaround workflow hiccups (CLA: python/core-workflow#366 and CI: python/core-workflow#367).

@vstinner
Copy link
Member

vstinner commented May 1, 2020

Hum, the bot which checks the CLA didn't add the label. I reported the issue at: python/core-workflow#366

I worked around this by adding and then removing "CLA not signed" label. The PR got the "CLA signed" label. Good.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miss-islington
Copy link
Contributor

@furkanonder: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 719e14d into python:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants