Skip to content

gh-130662: accept leading zeros in precision/width for Decimal's formatting #132549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 2, 2025

Conversation

skirpichev
Copy link
Contributor

@skirpichev skirpichev commented Apr 15, 2025

@vstinner

This comment was marked as resolved.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skirpichev skirpichev added the 3.14 bugs and security fixes label Apr 28, 2025
@skirpichev skirpichev added needs backport to 3.14 bugs and security fixes and removed 3.14 bugs and security fixes labels May 8, 2025
picnixz

This comment was marked as resolved.

@skirpichev skirpichev requested a review from picnixz June 2, 2025 11:38
@vstinner vstinner removed the needs backport to 3.14 bugs and security fixes label Jun 2, 2025
@vstinner vstinner merged commit 9c72658 into python:main Jun 2, 2025
41 checks passed
@picnixz picnixz removed the skip news label Jun 2, 2025
@vstinner
Copy link
Member

vstinner commented Jun 2, 2025

Merged, thank you.

I don't think that this change should be backported to stable branches.

@skirpichev skirpichev deleted the fix-fmt-decimal/130662 branch June 2, 2025 13:57
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label Jul 7, 2025
@miss-islington-app
Copy link

Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2025
…s formatting (pythonGH-132549)

(cherry picked from commit 9c72658)

Co-authored-by: Sergey B Kirpichev <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jul 7, 2025

GH-136362 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 7, 2025
hugovk pushed a commit that referenced this pull request Jul 7, 2025
…'s formatting (GH-132549) (#136362)

Co-authored-by: Sergey B Kirpichev <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants