-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
gh-103556: [inspect.Signature] disallow pos-or-kw params without default after pos-only with default #103557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
gh-103556: [inspect.Signature] disallow pos-or-kw params without default after pos-only with default #103557
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
578f998
gh-103556: [inspect.Signature] disallow pos-or-kw params without defa…
sobolevn a4cf538
Update Lib/test/test_inspect.py
sobolevn d6ef93a
Address review
sobolevn 261d9d1
Merge branch 'issue-103556' of https://github.com/sobolevn/cpython in…
sobolevn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
Misc/NEWS.d/next/Library/2023-04-15-12-19-14.gh-issue-103556.TEf-2m.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Now creating :class:`inspect.Signature` objects with positional-only | ||
parameter with a default followed by a positional-or-keyword parameter | ||
without one is impossible. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-default-after-default is only checked for
_POSITIONAL_ONLY
and_POSITIONAL_KEYWORD
(see line 3032.) So if we want to keep the value ofkind_defaults
across the transition from PO to POK (which I do agree is correct and matches the parser behavior), then really we always want to keep it, and it is no longerkind_defaults
but simplyseen_default
. So I think we can eliminate all of this, here's the full version I'd recommend (which passes all tests): https://gist.github.com/carljm/6779e601d04e0b1135444b4e0263e281There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree, thank you for the suggestion.