Skip to content

testing: use a tighter check if bash is available #7520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
The-Compiler merged 1 commit into from
Jul 20, 2020
Merged

testing: use a tighter check if bash is available #7520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions testing/test_parseopt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import argparse
import os
import shlex
import shutil
import subprocess
import sys

import py
Expand Down Expand Up @@ -288,8 +288,19 @@ def test_multiple_metavar_help(self, parser: parseopt.Parser) -> None:


def test_argcomplete(testdir, monkeypatch) -> None:
if not shutil.which("bash"):
pytest.skip("bash not available")
try:
bash_version = subprocess.run(
["bash", "--version"],
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
Copy link
Member

@graingert graingert Jul 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you only look at the .stdout, so I think it's cleaner with stderr=subprocess.DEVNULL ?

universal_newlines=True,
Copy link
Member

@graingert graingert Jul 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check=True here?

).stdout
except OSError:
pytest.skip("bash is not available")
if "GNU bash" not in bash_version:
# See #7518.
pytest.skip("not a real bash")

script = str(testdir.tmpdir.join("test_argcomplete"))

with open(str(script), "w") as fp:
Expand Down