Skip to content

Reintroduce PytestReturnNotNoneWarning #13495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nicoddemus
Copy link
Member

Since this warning is meant to be permanent, added proper documentation to the assert section in the docs.

Fixes #13477

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Jun 7, 2025
@nicoddemus
Copy link
Member Author

Do we consider this a bugfix that is OK to enter in the next patch release, or should we wait for 8.5?

@RonnyPfannschmidt
Copy link
Member

We should backport as we correct a regression

Since this warning is meant to be permanent, added proper documentation to the `assert` section in the docs.

Fixes pytest-dev#13477
@nicoddemus nicoddemus force-pushed the 13477-none-warning branch from 3c8dff2 to 1e1c68d Compare June 7, 2025 12:52
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think it's a bug fix to be backported

@nicoddemus nicoddemus added the backport 8.4.x apply to PRs at any point; backports the changes to the 8.4.x branch label Jun 7, 2025
@nicoddemus
Copy link
Member Author

I'm getting the same failure on main locally.

Testing main on #13496 to confirm the failure is unrelated to these changes.

@nicoddemus
Copy link
Member Author

Blocked by #13497, will wait for us to fix that before merging this.

@RonnyPfannschmidt
Copy link
Member

The related issue is possibly something larger to fix so id prefer we dont block on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 8.4.x apply to PRs at any point; backports the changes to the 8.4.x branch bot:chronographer:provided (automation) changelog entry is part of PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undocumented removal of PytestReturnNotNoneWarning
3 participants