Remove use of rsyncdir #558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
previously requested changes
Oct 26, 2022
Member
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
That particular example and the loops are actually correct and needed as is
We might need to revise the rsync dir details given thst we don't have a coverage combine test atm
ssbarnea
force-pushed
the
fix/rsyncdir-deprecation
branch
from
0242835 to
4865bec
Compare
Member
|
I'd remove it completely now. Best to deal with the breakage now than down the road when support for that option is gone. |
Member
Author
|
@ionelmc Any chance to approve it? |
|
Any word here folks? |
Member
|
Whoops missed this. Looks all good. |
|
Any chance of a pytest-cov to get this fix in? |
|
Please can we get a release here? |
Member
|
Later today there will be a 4.1 release (if no objections). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #557