Skip to content

Fix typing of backends #7114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 6, 2022
Merged

Fix typing of backends #7114

merged 4 commits into from
Oct 6, 2022

Conversation

headtr1ck
Copy link
Collaborator

While adding type hints to test_backends I noticed that the open_dataset method and the abstract BackendEntrypoint were missing stream types as inputs.

@github-actions github-actions bot added io and removed topic-typing labels Oct 2, 2022
@max-sixty
Copy link
Collaborator

Very impressive and thorough @headtr1ck , thank you...

@headtr1ck headtr1ck added the plan to merge Final call for comments label Oct 2, 2022
@headtr1ck
Copy link
Collaborator Author

Long rainy weekends with nothing else to do :)

@headtr1ck headtr1ck mentioned this pull request Oct 4, 2022
Merged
4 tasks
@headtr1ck headtr1ck merged commit 114bf98 into pydata:main Oct 6, 2022
@headtr1ck headtr1ck deleted the tt branch October 6, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
io plan to merge Final call for comments topic-backends topic-typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@headtr1ck @max-sixty