-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Support NumPy array API (experimental) #6804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
dc76862
Support NumPy array API (experimental)
tomwhite 14ef443
Address feedback
tomwhite ffbb602
Update xarray/core/indexing.py
tomwhite fe33202
Update xarray/core/indexing.py
tomwhite 0da1f5e
Update xarray/tests/test_array_api.py
tomwhite 7e91bd5
Update xarray/tests/test_array_api.py
tomwhite fa9ea14
Update xarray/tests/test_array_api.py
tomwhite 3cc3cb4
Update xarray/tests/test_array_api.py
tomwhite f6df255
Update xarray/tests/test_array_api.py
tomwhite afe3d9f
Fix import order
tomwhite 0f81209
Fix import order
dcherian 6d7f13e
update whatsnew
TomNicholas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
from typing import Tuple | ||
|
||
import pytest | ||
|
||
import xarray as xr | ||
from xarray.testing import assert_equal | ||
|
||
np = pytest.importorskip("numpy", minversion="1.22") | ||
|
||
import numpy.array_api as xp # isort:skip | ||
from numpy.array_api._array_object import Array # isort:skip | ||
|
||
|
||
@pytest.fixture | ||
def arrays() -> Tuple[xr.DataArray, xr.DataArray]: | ||
np_arr = xr.DataArray(np.ones((2, 3)), dims=("x", "y"), coords={"x": [10, 20]}) | ||
xp_arr = xr.DataArray(xp.ones((2, 3)), dims=("x", "y"), coords={"x": [10, 20]}) | ||
assert isinstance(xp_arr.data, Array) | ||
return np_arr, xp_arr | ||
|
||
|
||
def test_arithmetic(arrays) -> None: | ||
np_arr, xp_arr = arrays | ||
expected = np_arr + 7 | ||
actual = xp_arr + 7 | ||
assert isinstance(actual.data, Array) | ||
assert_equal(actual, expected) | ||
|
||
|
||
def test_aggregation(arrays) -> None: | ||
np_arr, xp_arr = arrays | ||
expected = np_arr.sum(skipna=False) | ||
actual = xp_arr.sum(skipna=False) | ||
assert isinstance(actual.data, Array) | ||
assert_equal(actual, expected) | ||
|
||
|
||
def test_indexing(arrays) -> None: | ||
np_arr, xp_arr = arrays | ||
expected = np_arr[:, 0] | ||
actual = xp_arr[:, 0] | ||
assert isinstance(actual.data, Array) | ||
assert_equal(actual, expected) | ||
|
||
|
||
def test_reorganizing_operation(arrays) -> None: | ||
np_arr, xp_arr = arrays | ||
expected = np_arr.transpose() | ||
actual = xp_arr.transpose() | ||
assert isinstance(actual.data, Array) | ||
assert_equal(actual, expected) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.