Warn when grouping by dask array. #6788
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Illviljan
approved these changes
Jul 15, 2022
| if not isinstance(group, _DummyGroup) and is_duck_dask_array(group.data): | ||
| warnings.warn( | ||
| "Grouping by a dask array computes that array. " | ||
| "This will raise an error in the future. " |
There was a problem hiding this comment.
My naive dream would have been that it successfully grouped the dask array lazily in the future. But that's maybe for the even further future if even possible?
There was a problem hiding this comment.
🤦 I don't know what I was thinking...
Yes we can now do that with flox...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently computes eagerly; we want to not do that in the future
(broken out from #6689)