Skip to content

add a fallback_version to the setuptools_scm configuration #4358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2020

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Aug 20, 2020

Follow-up to #4299. While investigating version issues on RTD, I noticed that setuptools_scm allows configuring its behavior, and the custom try: ... except ... clause can be replaced by setting fallback_version. The advantage is that once we switch to pyproject.toml (for which we need to drop python 3.6), the changes are much more straightforward.

cc @crusaderky

@crusaderky crusaderky self-requested a review August 22, 2020 14:39
Copy link
Contributor

@crusaderky crusaderky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, it works. Good catch.

@crusaderky crusaderky merged commit 2bc8e33 into pydata:master Aug 22, 2020
@keewis keewis deleted the fix-setup branch August 22, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants